summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorReinhold Gschweicher <pyro4hell@gmail.com>2021-11-19 23:14:19 +0100
committerJF <JF002@users.noreply.github.com>2022-03-03 21:15:57 +0100
commit5613449bfb16ed7bac672621f0f6c13afb1e1718 (patch)
tree73cf744ad8c36b1b5aeab7c64026b9442e1e6c57
parentdd47ba9782cb7a7a2268da5b493e6d385bdf08af (diff)
Settings: more specific read and write mode
For each filesystem interaction be more specific if we want to read from the file or write to it. Doing a non-creating read on the loading of the settings file, otherwise an empty file could be created, and when reading that empty file for the initial settings I would expect an error (or random data) when reading.
-rw-r--r--src/components/settings/Settings.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/components/settings/Settings.cpp b/src/components/settings/Settings.cpp
index ef73ad1c..fee62daf 100644
--- a/src/components/settings/Settings.cpp
+++ b/src/components/settings/Settings.cpp
@@ -26,7 +26,7 @@ void Settings::LoadSettingsFromFile() {
SettingsData bufferSettings;
lfs_file_t settingsFile;
- if ( fs.FileOpen(&settingsFile, "/settings.dat", LFS_O_RDWR | LFS_O_CREAT) != LFS_ERR_OK) {
+ if ( fs.FileOpen(&settingsFile, "/settings.dat", LFS_O_RDONLY) != LFS_ERR_OK) {
return;
}
fs.FileRead(&settingsFile, reinterpret_cast<uint8_t*>(&bufferSettings), sizeof(settings));
@@ -39,7 +39,7 @@ void Settings::LoadSettingsFromFile() {
void Settings::SaveSettingsToFile() {
lfs_file_t settingsFile;
- if ( fs.FileOpen(&settingsFile, "/settings.dat", LFS_O_RDWR | LFS_O_CREAT) != LFS_ERR_OK) {
+ if ( fs.FileOpen(&settingsFile, "/settings.dat", LFS_O_WRONLY | LFS_O_CREAT) != LFS_ERR_OK) {
return;
}
fs.FileWrite(&settingsFile, reinterpret_cast<uint8_t*>(&settings), sizeof(settings));