diff options
author | JF <JF002@users.noreply.github.com> | 2021-11-15 20:44:31 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-11-15 20:44:31 +0100 |
commit | 624429b54c1819d58b69a2f74f5c852e1ecb0ed3 (patch) | |
tree | f198b2a0fd99f00278316496bf263e85e5338a28 /src/drivers/Cst816s.cpp | |
parent | a57fda6ba4a29866083a1254ffdf92939d00e182 (diff) | |
parent | 9671a8451fc0bc49fcd06521906d8be53959a74f (diff) |
Merge pull request #830 from InfiniTimeOrg/fix-unresponsive-touchpanel
Fix unresponsive touch panel after update to 1.7
Diffstat (limited to 'src/drivers/Cst816s.cpp')
-rw-r--r-- | src/drivers/Cst816s.cpp | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/src/drivers/Cst816s.cpp b/src/drivers/Cst816s.cpp index 4aac19f9..bf51a8ba 100644 --- a/src/drivers/Cst816s.cpp +++ b/src/drivers/Cst816s.cpp @@ -32,17 +32,11 @@ bool Cst816S::Init() { twiMaster.Read(twiAddress, 0xa7, &dummy, 1); vTaskDelay(5); - static constexpr uint8_t maxRetries = 3; - bool isDeviceOk; - uint8_t retries = 0; - do { - isDeviceOk = CheckDeviceIds(); - retries++; - } while (!isDeviceOk && retries < maxRetries); - - if (!isDeviceOk) { - return false; - } + // TODO This function check that the device IDs from the controller are equal to the ones + // we expect. However, it seems to return false positive (probably in case of communication issue). + // Also, it seems that some users have pinetimes that works correctly but that report different device IDs + // Until we know more about this, we'll just read the IDs but not take any action in case they are not 'valid' + CheckDeviceIds(); /* [2] EnConLR - Continuous operation can slide around |